[webkit-reviews] review granted: [Bug 91782] [WK2] REGRESSION r122966: Crash when closing tab with Web Inspector open in WebKit::PageOverlay : [Attachment 153667] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 91782: [WK2] REGRESSION r122966: Crash when closing tab with Web Inspector
open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782

Attachment 153667: Patch
https://bugs.webkit.org/attachment.cgi?id=153667&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153667&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:567
> +    if ((m_highlightData && (m_highlightData->rect ||
m_highlightData->node)) || !m_pausedInDebuggerMessage.isNull())

Consider extracting this logic into hasHighlightData() as it is used used in 
InspectorOverlay::drawHighlight as well.