[webkit-reviews] review granted: [Bug 91936] [WIN] Use GetTimeZoneInformation() for getting the timezone name : [Attachment 153686] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 91936: [WIN] Use GetTimeZoneInformation() for getting the timezone name
https://bugs.webkit.org/show_bug.cgi?id=91936

Attachment 153686: Patch
https://bugs.webkit.org/attachment.cgi?id=153686&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153686&action=review


> Source/JavaScriptCore/runtime/DateConversion.cpp:93
> +    DWORD result = GetTimeZoneInformation(&timeZoneInformation);

I would have named this variable daylightType instead.

> Source/JavaScriptCore/runtime/DateConversion.cpp:94
> +    CString timeZoneNameString = String(result == TIME_ZONE_ID_DAYLIGHT ?
timeZoneInformation.DaylightName : timeZoneInformation.StandardName).latin1();

It's unfortunate that we have to convert WCHAR to char here.
I would use ascii().data() instead possibly allocating String as a local
variable.