[webkit-reviews] review granted: [Bug 91921] [WIN] Remove ICU dependencies from UniscribeController : [Attachment 153662] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 23 01:09:19 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 91921: [WIN] Remove ICU dependencies from UniscribeController
https://bugs.webkit.org/show_bug.cgi?id=91921

Attachment 153662: Patch
https://bugs.webkit.org/attachment.cgi?id=153662&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153662&action=review


> Source/WebCore/platform/graphics/win/UniscribeController.cpp:151
> +	   bool forceSmallCaps = isSmallCaps && (category(*curr) &
(Mark_NonSpacing | Mark_Enclosing | Mark_SpacingCombining));

It's probably better to use c here instead of *curr.


More information about the webkit-reviews mailing list