[webkit-reviews] review granted: [Bug 91941] Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively : [Attachment 153691] Patch 2

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 91941: Rename ENABLE_METER_TAG and ENABLE_PROGRESS_TAG to
ENABLE_METER_ELEMENT and ENABLE_PROGRESS_ELEMENT respectively
https://bugs.webkit.org/show_bug.cgi?id=91941

Attachment 153691: Patch 2
https://bugs.webkit.org/attachment.cgi?id=153691&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153691&action=review


> Source/WebCore/html/shadow/MeterShadowElement.h:87
> +#endif
>  #endif

If there are two or more #endif s, we want to put '#endif // METER_ELEMENT' and
'#endif // MeterShadowElement_h'.

> Source/WebCore/html/shadow/ProgressShadowElement.h:88
> +#endif
>  #endif

Ditto.

> LayoutTests/fast/dom/wrapper-classes.html:281
> +    // Conditional elements, VIDEO, PROGRESS_ELEMENT, RUBY,
DATALIST_ELEMENT, METER_ELEMENT.

Nit: DATALIST => DATALIST_ELEMENT is intended? Looks good though.