[webkit-reviews] review granted: [Bug 91897] [Texmap] Performance regression in texture uploads after r121223 : [Attachment 153579] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jul 22 10:44:13 PDT 2012
Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 91897: [Texmap] Performance regression in texture uploads after r121223
https://bugs.webkit.org/show_bug.cgi?id=91897
Attachment 153579: Patch
https://bugs.webkit.org/attachment.cgi?id=153579&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153579&action=review
> Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp:155
> +const uint8_t* GraphicsContext3D::extractRawImageData(Image* image)
why not just rawImageData?
> Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:490
> #endif
>
> +
> +
> +// Extracts the contents of the given Image without copying or formatting.
why so many newlines?
More information about the webkit-reviews
mailing list