[webkit-reviews] review denied: [Bug 91782] [WK2] REGRESSION (r122919-r122969): Crash when closing tab with Web Inspector open in WebKit::PageOverlay : [Attachment 153665] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 91782: [WK2] REGRESSION (r122919-r122969): Crash when closing tab with Web
Inspector open in WebKit::PageOverlay
https://bugs.webkit.org/show_bug.cgi?id=91782

Attachment 153665: Patch
https://bugs.webkit.org/attachment.cgi?id=153665&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153665&action=review


> Source/WebCore/inspector/DOMNodeHighlighter.cpp:536
> +	   update();

This change will only mask the crash - it will still happen in case there was a
highlighted node upon page destruction.

> Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp:70
> +    if (!frameView)

So this seems to be fixing crash, but we should not be getting here from the
page destructor. The proper fix would be to mute InspectorOverlay from within
InspectorController::inspectedPageDestroyed().