[webkit-reviews] review denied: [Bug 91890] nrwt: never finds binaries in the 'out' dir on chromium win : [Attachment 153584] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 91890: nrwt: never finds binaries in the 'out' dir on chromium win
https://bugs.webkit.org/show_bug.cgi?id=91890

Attachment 153584: Patch
https://bugs.webkit.org/attachment.cgi?id=153584&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153584&action=review


> Tools/ChangeLog:11
> +	   chromium-win's case, we look in src/build, which always exists
because there
> +	  are checked-in files in it, which means we'd always pick that

Nit: weird indent

> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:389
> +    def _build_path(self, *comps, **kwargs):
> +	   return self._static_build_path(self._filesystem,
self.get_option('build_directory'), self.path_from_chromium_base(),
self.path_from_webkit_base(), configuration=(kwargs.get('configuration') or
self.get_option('configuration')), comps=comps)

Rather than overloading this functions with kwargs, I think it would be more
clear to add a new method _build_path_with_configuration(self, configuration,
*comps).