[webkit-reviews] review granted: [Bug 83370] [chromium] Scratch texture reused before SkBitmap releases ownership : [Attachment 153576] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 20 13:29:32 PDT 2012
Adrienne Walker <enne at google.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 83370: [chromium] Scratch texture reused before SkBitmap releases ownership
https://bugs.webkit.org/show_bug.cgi?id=83370
Attachment 153576: Patch
https://bugs.webkit.org/attachment.cgi?id=153576&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153576&action=review
R=me. Wow, GrAutoScratchTexture is way better than manual locking and
unlocking.
> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:207
> + GrAutoScratchTexture ast(gr, desc,
GrContext::kExact_ScratchTexMatch);
> + SkAutoTUnref<GrTexture> dest(ast.detach());
style nit: Argh, abbreviations.
More information about the webkit-reviews
mailing list