[webkit-reviews] review granted: [Bug 91887] [BlackBerry] Add Cancel button for Select popup : [Attachment 153556] patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Crystal Zhang
<haizhang at rim.com>'s request for review:
Bug 91887: [BlackBerry] Add Cancel button for Select popup
https://bugs.webkit.org/show_bug.cgi?id=91887

Attachment 153556: patch
https://bugs.webkit.org/attachment.cgi?id=153556&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153556&action=review


> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:151
> +    // "-1" means cancel.
> +    if (stringValue.contains("-1")) {

nit: I would remove the comment, and make the code self-explanatory :)

DEFINE_STATIC_LOCAL("-1", cancelValue)
if (string.contains(cancelValue)) {
    blah;