[webkit-reviews] review granted: [Bug 88271] Introduce WebViewBenchmarkSupport for performance experiments on a real WebView : [Attachment 153054] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Daniel Murphy
<dmurph at chromium.org>'s request for review:
Bug 88271: Introduce WebViewBenchmarkSupport for performance experiments on a
real WebView
https://bugs.webkit.org/show_bug.cgi?id=88271

Attachment 153054: Patch
https://bugs.webkit.org/attachment.cgi?id=153054&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153054&action=review


> Source/WebKit/chromium/src/WebViewBenchmarkSupportImpl.cpp:76
> +    case PaintModeEverything: {

nit: no {}'s for this case.  you aren't declaring a variable.

> Source/WebKit/chromium/src/WebViewBenchmarkSupportImpl.cpp:101
> +	   acceleratedPaintUnclipped(paintClient, *layer);

nit: add a "break;" at the end of this case, so you don't have to remember to
add one later
when you add the other cases.