[webkit-reviews] review granted: [Bug 91801] [Chromium] Add WebView::zoomToFindInPageRect for Android : [Attachment 153380] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 20 10:05:57 PDT 2012
Tony Chang <tony at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 91801: [Chromium] Add WebView::zoomToFindInPageRect for Android
https://bugs.webkit.org/show_bug.cgi?id=91801
Attachment 153380: Patch
https://bugs.webkit.org/attachment.cgi?id=153380&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153380&action=review
> Source/WebKit/chromium/src/WebViewImpl.cpp:1087
> + double durationSec = isDoubleTap ? 0.25 : 0;
Nit: Should we move .25 into a named constant? Also, durationSec ->
durationSeconds
More information about the webkit-reviews
mailing list