[webkit-reviews] review granted: [Bug 91857] [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport object at shutdown : [Attachment 153501] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Tommy Widenflycht
<tommyw at google.com>'s request for review:
Bug 91857: [chromium] MediaStream API: Clean up the MockWebKitPlatformSupport
object at shutdown
https://bugs.webkit.org/show_bug.cgi?id=91857

Attachment 153501: Patch
https://bugs.webkit.org/attachment.cgi?id=153501&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153501&action=review


> Tools/DumpRenderTree/chromium/DumpRenderTree.cpp:85
> +    OwnPtr<MockWebKitPlatformSupport> mockPlatform;

mockPlatform -> m_mockPlatform

> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:38
> -Platform* MockWebKitPlatformSupport::create()
> +MockWebKitPlatformSupport* MockWebKitPlatformSupport::create()

Should this return a PassOwnPtr?

> Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h:39
> +    ~MockWebKitPlatformSupport() { }

Please move this declaration out of line.