[webkit-reviews] review granted: [Bug 91865] [chromium] Enable the GPU-accelerated skia path for SVG lighting filters : [Attachment 153511] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 20 08:51:03 PDT 2012
Dirk Schulze <krit at webkit.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 91865: [chromium] Enable the GPU-accelerated skia path for SVG lighting
filters
https://bugs.webkit.org/show_bug.cgi?id=91865
Attachment 153511: Patch
https://bugs.webkit.org/attachment.cgi?id=153511&action=review
------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153511&action=review
LGTM. r=me.
> Source/WebCore/platform/graphics/filters/skia/FELightingSkia.cpp:90
> + if (!limitingConeAngle || limitingConeAngle > 90.0f ||
limitingConeAngle < -90.0f)
Omit the .0f every please. This is against style rules.
More information about the webkit-reviews
mailing list