[webkit-reviews] review granted: [Bug 91847] [chromium] Don't include WebCore headers in TestInterfaces so it's safe to include from outside of WebCore : [Attachment 153462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 20 08:38:50 PDT 2012


Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 91847: [chromium] Don't include WebCore headers in TestInterfaces so it's
safe to include from outside of WebCore
https://bugs.webkit.org/show_bug.cgi?id=91847

Attachment 153462: Patch
https://bugs.webkit.org/attachment.cgi?id=153462&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153462&action=review


> Tools/DumpRenderTree/chromium/TestRunner/TestInterfaces.h:48
> +    class Internal;
> +    Internal* m_internal;

Isn't there an OwnPtr-like class we can use from the WebKit API?  WebPrivatePtr
or something?


More information about the webkit-reviews mailing list