[webkit-reviews] review denied: [Bug 91759] Web Inspector: count RenderStyle objects in the native memory profiler : [Attachment 153479] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 20 04:46:29 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91759: Web Inspector: count RenderStyle objects in the native memory
profiler
https://bugs.webkit.org/show_bug.cgi?id=91759

Attachment 153479: Patch
https://bugs.webkit.org/attachment.cgi?id=153479&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153479&action=review


> Source/WebCore/rendering/style/RenderStyle.cpp:1490
> +struct InstrumentedRenderStyle : public RefCounted<InstrumentedRenderStyle>
{

I like the approach, but it puts additional burden to the developers. We need
to agree on the approach in webkit-dev prior to proceeding.


More information about the webkit-reviews mailing list