[webkit-reviews] review denied: [Bug 91734] Web Inspector: native memory instrumentation: cover MemoryCache with MemoryInstrumentation : [Attachment 153256] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 91734: Web Inspector: native memory instrumentation: cover MemoryCache with
MemoryInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=91734

Attachment 153256: Patch
https://bugs.webkit.org/attachment.cgi?id=153256&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153256&action=review


> Source/WebCore/loader/cache/CachedResource.cpp:783
> +    MemoryClassInfo<CachedResource> info(memoryObjectInfo, this,
MemoryInstrumentation::CachedResource);

Lets make sure there is a way to maintain this code consistently. What if
someone adds a field? How do we make sure we update this method?