[webkit-reviews] review denied: [Bug 91617] Web Inspector: count DOM storage cache memory for native snapshot : [Attachment 152997] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 91617: Web Inspector: count DOM storage cache memory for native snapshot
https://bugs.webkit.org/show_bug.cgi?id=91617

Attachment 152997: Patch
https://bugs.webkit.org/attachment.cgi?id=152997&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152997&action=review


> Source/WebCore/inspector/InspectorMemoryAgent.cpp:639
> +    size_t size =
instrumentingAgents->inspectorDOMStorageAgent()->memoryBytesUsedByStorageCache(
);

You should never access agents in instrumentingAgents, only
InspecorInstrumentation can do that.