[webkit-reviews] review denied: [Bug 91607] Web Inspector: Protocol Extension: add getNamedFlowCollection command : [Attachment 153444] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 20 01:49:03 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied  review:
Bug 91607: Web Inspector: Protocol Extension: add getNamedFlowCollection
command
https://bugs.webkit.org/show_bug.cgi?id=91607

Attachment 153444: Patch
https://bugs.webkit.org/attachment.cgi?id=153444&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153444&action=review


> Source/WebCore/dom/WebKitNamedFlowCollection.h:33
> +#include <InspectorBackendDispatcher.h>

You should not make arbitrary component depend on the inspector guts. Also,
these are not visible in case of !ENABLED(INSPECTOR). You should return a
Vector<String> instead.


More information about the webkit-reviews mailing list