[webkit-reviews] review granted: [Bug 85444] Crash in webkitAddKey() when key parameter is null : [Attachment 152791] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted David Dorwin
<ddorwin at chromium.org>'s request for review:
Bug 85444: Crash in webkitAddKey() when key parameter is null
https://bugs.webkit.org/show_bug.cgi?id=85444

Attachment 152791: Patch
https://bugs.webkit.org/attachment.cgi?id=152791&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152791&action=review


>>> Source/WebCore/ChangeLog:7
>>> +
>> 
>> Would you add the link to the spec that supports your change? The change
looks good but I am not sure if SYNTAX_ERR is the expected error.
> 
>
http://dvcs.w3.org/hg/html-media/raw-file/a70cac1c6d77/encrypted-media/encrypte
d-media.html#dom-addkey step 1. I had to update it to handle the second
argument, but the first argument has always been a SYNTAX_ERR. If there is a
better or more appropriate way of handling these cases, I can update this patch
and the spec.

Thanks. Looks OK. Please describe the link and the explanation you described in
bugzilla to this ChangeLog.