[webkit-reviews] review granted: [Bug 85527] [Qt][WK2] Add support for multi-select list : [Attachment 153299] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 85527: [Qt][WK2] Add support for multi-select list
https://bugs.webkit.org/show_bug.cgi?id=85527

Attachment 153299: Patch
https://bugs.webkit.org/attachment.cgi?id=153299&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153299&action=review


I think this is fine for the initial commit. Why no test?

> Source/WebKit2/Shared/PlatformPopupMenuData.cpp:69
> +#elif PLATFORM(QT)
> +    encoder->encode(multipleSelections);
>  #endif

Other ports might want this, maybe we can find another define

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:63
> +    void selectItem(int);

isnt this more of a toggleItem? im just wondering

> Source/WebKit2/UIProcess/qt/WebPopupMenuProxyQt.cpp:145
> +    if ((index == -1 ) && m_items.multiple())

some werd space there