[webkit-reviews] review granted: [Bug 90604] [EFL] [WK2] Add methods to get/set a custom text encoding : [Attachment 153270] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Sudarsana Nagineni
(babu) <naginenis at gmail.com>'s request for review:
Bug 90604: [EFL] [WK2] Add methods to get/set a custom text encoding
https://bugs.webkit.org/show_bug.cgi?id=90604

Attachment 153270: Patch
https://bugs.webkit.org/attachment.cgi?id=153270&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153270&action=review


I guess this is OK, though I wonder how much it makes sense to store a local
copy of the encoding name as a shared string.

> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:989
> +	   WKPageSetCustomTextEncodingName(toAPI(priv->pageClient->page()),
wkEncodingName.get());
> +    return true;

newline before return