[webkit-reviews] review granted: [Bug 91006] Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client : [Attachment 152754] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 16:21:43 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 91006: Unify numTouchEventHandlersChanged and needTouchEvents in the chrome
client
https://bugs.webkit.org/show_bug.cgi?id=91006

Attachment 152754: Patch
https://bugs.webkit.org/attachment.cgi?id=152754&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152754&action=review


> Source/WebCore/dom/Document.cpp:5958
> +    if (Page* page = this->page())
> +	   page->chrome()->client()->needTouchEvents(true);

Shouldn't we check that we had not already called needTouchEvents with true by
going through frames?


More information about the webkit-reviews mailing list