[webkit-reviews] review granted: [Bug 91768] Replaceable attributes should also have readonly : [Attachment 153355] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 91768: Replaceable attributes should also have readonly
https://bugs.webkit.org/show_bug.cgi?id=91768

Attachment 153355: Patch
https://bugs.webkit.org/attachment.cgi?id=153355&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153355&action=review


r=me assuming this doesn't break ObjC bindings.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:1221
> -	   if ($attribute->type =~ /readonly/) {
> +	   if ($attribute->type =~ /readonly/ &&
!$attribute->signature->extendedAttributes->{"Replaceable"}) {

Should we make a helper function that does this instead of copy/pasting it
everywhere?

> Source/WebCore/page/DOMWindow.idl:55
> +	   readonly attribute [Replaceable] Navigator navigator;

I'm surprised this doesn't break the ObjC bindings.  Does ObjC not have setters
for all of these?