[webkit-reviews] review granted: [Bug 91651] [Chromium] Support external autofill popups : [Attachment 153347] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 14:50:56 PDT 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 91651: [Chromium] Support external autofill popups
https://bugs.webkit.org/show_bug.cgi?id=91651

Attachment 153347: Patch
https://bugs.webkit.org/attachment.cgi?id=153347&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153347&action=review


> Source/WebKit/chromium/ChangeLog:8
> +	   This looks like the last piece of needed to support external
autofill

nit: "last piece [--of--] needed to support external"

> Source/WebKit/chromium/ChangeLog:9
> +	   popups. This funtion just lets the embedder select an index
(presumably

nit: funtion -> function


More information about the webkit-reviews mailing list