[webkit-reviews] review granted: [Bug 91537] [Chromium] Textures drawn during occlusion are incorrectly re-used when unoccluded. : [Attachment 153329] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted zlieber at chromium.org's request
for review:
Bug 91537: [Chromium] Textures drawn during occlusion are incorrectly re-used
when unoccluded.
https://bugs.webkit.org/show_bug.cgi?id=91537

Attachment 153329: Patch
https://bugs.webkit.org/attachment.cgi?id=153329&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153329&action=review


R=me.  The tests are great.  :)

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:455
> +    if (hasOcclusionFromOutsideTargetSurface)
> +	   *hasOcclusionFromOutsideTargetSurface =
(intersection(unoccludedInScreen, unoccludedInTarget) != unoccludedInTarget);
> +
> +    if (unoccludedInScreen.isEmpty())
> +	   return unoccludedInScreen;
> +
>      return intersection(unoccludedInScreen, unoccludedInTarget);

I don't think you need this second if statement.

> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:512
> +    if (unoccludedInScreen.isEmpty())
> +	   return unoccludedInScreen;
> +

Nor this.