[webkit-reviews] review granted: [Bug 91744] Web Inspector: minimize number of properties on WebInspector.TimelinePresentationModel.Record : [Attachment 153263] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 91744: Web Inspector: minimize number of properties on
WebInspector.TimelinePresentationModel.Record
https://bugs.webkit.org/show_bug.cgi?id=91744

Attachment 153263: Patch
https://bugs.webkit.org/attachment.cgi?id=153263&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153263&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:391
> +    this._style =
WebInspector.TimelinePresentationModel.recordStyle(record);

This could be done lazily.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:517
> +    get category()

Please annotate new members.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:519
> +	   return this._style.category

Inline _style here.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:524
> +	   return this.type === WebInspector.TimelineModel.RecordType.TimeStamp
? this._record.data["message"] : this._style.title;

Inline _style here.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:562
> +    get _selfTime()

We never do private getters.

> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:571
> +    },

return null;