[webkit-reviews] review granted: [Bug 91689] [BlackBerry] Only maintain the hole punch rect while html5 video is being renderered : [Attachment 153128] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Max Feil <mfeil at rim.com>'s
request for review:
Bug 91689: [BlackBerry] Only maintain the hole punch rect while html5 video is
being renderered
https://bugs.webkit.org/show_bug.cgi?id=91689

Attachment 153128: Patch
https://bugs.webkit.org/attachment.cgi?id=153128&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153128&action=review


Good stuff

Nit: comments in the code need period at the end. Please reupload with
"Reviewed by Antonio Gomes" and only ask for commit-queue. No need to get it
reviewed again.

>
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:51
2
> +	       // Remove media player from platform layer (removes hole punch
rect)

comments are real sentenses

>
Source/WebCore/platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:52
5
> +	       // Create platform layer for video (creates hole punch rect)

ditto