[webkit-reviews] review denied: [Bug 91728] Web Inspector: Drag and drop should not be started on right mouse click. : [Attachment 153257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 07:33:14 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 91728: Web Inspector: Drag and drop should not be started on right mouse
click.
https://bugs.webkit.org/show_bug.cgi?id=91728

Attachment 153257: Patch
https://bugs.webkit.org/attachment.cgi?id=153257&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153257&action=review


> Source/WebCore/inspector/front-end/DataGrid.js:656
> +		   WebInspector.installDragStarter(resizer,
this._startResizerDragging.bind(this));

DragHandle ?

Could you instead pass all parameters into installDragHandle and get rid of
elementDragStart?


More information about the webkit-reviews mailing list