[webkit-reviews] review denied: [Bug 91630] Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously : [Attachment 153215] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 19 03:07:08 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 91630: Web Inspector: Incorrect XHR responses when two async xhrs are sent
synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630
Attachment 153215: Patch
https://bugs.webkit.org/attachment.cgi?id=153215&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153215&action=review
> LayoutTests/http/tests/inspector/network-test.js:28
> +function doXHR(method, url, async, callback, payload)
callback should be the last parameter for consistency.
If you don't want to update other tests you can introduce a new
doXHRWithPayload and reuse it in doXHR.
> LayoutTests/http/tests/inspector/network/network-xhr-async-double.html:19
> + console.log('both loaded');
Could you please replace it with "Done." for consistency with other tests.
> LayoutTests/http/tests/inspector/network/network-xhr-async-double.html:60
> + InspectorTest.assertTrue(request1.content=='request1' &&
request2.content=='request2');
We use === in javascript.
Also please add spaces around it.
Let's dump xhrs content here as well.
> LayoutTests/http/tests/inspector/network/network-xhr-async-double.html:67
> +<body onload="runTest()"></body>
Please add a brief description of what you are testing here and a link to the
bug.
> LayoutTests/http/tests/inspector/network/resources/echo.php:1
> +<?php
Please give a name that makes more sense, e.g. echo-payload.php
> LayoutTests/http/tests/inspector/network/resources/echo.php:2
> +
Please remove this line.
More information about the webkit-reviews
mailing list