[webkit-reviews] review granted: [Bug 91714] Web Inspector: Timeline: forward compatibility for load. : [Attachment 153184] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 19 02:13:16 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted eustas.bug at gmail.com's
request for review:
Bug 91714: Web Inspector: Timeline: forward compatibility for load.
https://bugs.webkit.org/show_bug.cgi?id=91714

Attachment 153184: Patch
https://bugs.webkit.org/attachment.cgi?id=153184&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153184&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:66
> +	   var recordTypes = WebInspector.TimelineModel.RecordType;

Maybe extract _initRecordStyles() ?

> LayoutTests/inspector/timeline/timeline-load-incompatible.html:43
> +Tests the Timeline save/load of unknown (incompatible) record types.

Please add a link to the bug below.


More information about the webkit-reviews mailing list