[webkit-reviews] review denied: [Bug 91716] [Refactoring] Use userAgentShadowRoot() for elements having user agent shadow root. : [Attachment 153196] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 91716: [Refactoring] Use userAgentShadowRoot() for elements having user
agent shadow root.
https://bugs.webkit.org/show_bug.cgi?id=91716

Attachment 153196: Patch
https://bugs.webkit.org/attachment.cgi?id=153196&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153196&action=review


> Source/WebCore/dom/ShadowRoot.cpp:146
> +    if (RefPtr<DocumentFragment> fragment =
createFragmentForInnerOuterHTML(markup, host()->document()->documentElement(),
AllowScriptingContent, ec))

How is this related to this change?

> Source/WebCore/html/HTMLImageElement.cpp:115
> +    if (ShadowRoot* userAgent = userAgentShadowRoot()) {

Could you consider the variable name? It's ridiculous to call it userAgent.