[webkit-reviews] review granted: [Bug 91679] IndexedDB: Throw native TypeErrors per spec : [Attachment 153144] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Joshua Bell
<jsbell at chromium.org>'s request for review:
Bug 91679: IndexedDB: Throw native TypeErrors per spec
https://bugs.webkit.org/show_bug.cgi?id=91679

Attachment 153144: Patch
https://bugs.webkit.org/attachment.cgi?id=153144&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
>> IMHO, this behavior sounds a bit strange to me. Given that these exceptions
are raised from inside DOM, DOMException objects sounds more reasonable to me.
What about other browsers?
>
> See comment #2.

Thanks. I understood. (though TypeError sounds a bit strange to me:-)

>> Do you know any other code that is doing something like this? (i.e. convert
a special DOMException to JavaScript Error in the binding layer)
>
> No. Alternate suggestions welcome.

Given that this fix is needed in IDB only, I think your approach is simple and
good. If we encountered other code that needs the fix, let's consider how we
can generalize it.