[webkit-reviews] review granted: [Bug 91667] Use native (non-cygwin) binaries for perl, gperf, and bison in Chromium : [Attachment 153084] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 91667: Use native (non-cygwin) binaries for perl, gperf, and bison in
Chromium
https://bugs.webkit.org/show_bug.cgi?id=91667

Attachment 153084: Patch
https://bugs.webkit.org/attachment.cgi?id=153084&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153084&action=review


Thanks for the great speed-up.

> Source/WebCore/make-hash-tools.pl:35
>      my $colorDataGperf	      = $ARGV[0];
> +    my $customGperf		      = $ARGV[1];
> +    shift;
>      shift;

Nit: You can write like this:

    my $colorDataGperf = shift;
    my $customGperf = shift;