[webkit-reviews] review requested: [Bug 89428] enable Web Audio for chromium android port : [Attachment 148258] Patch

[bugzilla-daemon at webkit.org]

Wei James <james.wei at intel.com> has asked  for review:
Bug 89428: enable Web Audio for chromium android port
https://bugs.webkit.org/show_bug.cgi?id=89428

Attachment 148258: Patch
https://bugs.webkit.org/attachment.cgi?id=148258&action=review

------- Additional Comments from Wei James <james.wei at intel.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148258&action=review


>> Source/WTF/wtf/Atomics.h:109
>> +#define WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED 1
> 
> This should be defined in Platform.h. Certain versions of the Android NDK had
issues with thread-safe reference counting, which is why this wasn't enabled
yet, but I *think* it's fine to be enabled now. I'll verify this downstream.

for other platforms this MACRO is also defined in this file. Should I keep it
here for consistency or move all the definition to Platform.h? thanks

>> Source/WebCore/WebCore.gyp/WebCore.gyp:1423
>> +	    ['"WTF_USE_WEBAUDIO_FFMPEG=1" in feature_defines', {
> 
> As said, none of FFMPEG is available in Android builds right now. We will
need to find a way around this..

I used the FFTFrame Stub to bring up web audio. and will implement another
FFTFrame for android like FFTFrameAndroid or FFTFrameOpenMax later.

is this ok? thanks 

To get rid of ffmpeg on android, I change the features.gypi to undefine
WTF_USE_WEBAUDIO_FFMPEG.