[webkit-reviews] review granted: [Bug 91594] Form state restore: Classify form control sates by owners in internal and serialized representations : [Attachment 152963] Patch 2

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 91594: Form state restore: Classify form control sates by owners in
internal and serialized representations
https://bugs.webkit.org/show_bug.cgi?id=91594

Attachment 152963: Patch 2
https://bugs.webkit.org/attachment.cgi?id=152963&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152963&action=review


Another possible approach might be to define a per-key values class and use Set
instead if Map.
The advantage of that serialization is more self-contained.
This is just idea though.

> Source/WebCore/html/FormController.cpp:225
> +    stateVector.append(String::number(m_controlStateCount));

We can just count this here instead of maintaining m_controlStateCount.
It's just another loop after all...