[webkit-reviews] review granted: [Bug 91511] [Mac] Make WebDataSourcePrivate lighter : [Attachment 153139] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 18 16:54:29 PDT 2012


Anders Carlsson <andersca at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 91511: [Mac] Make WebDataSourcePrivate lighter
https://bugs.webkit.org/show_bug.cgi?id=91511

Attachment 153139: Patch
https://bugs.webkit.org/attachment.cgi?id=153139&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153139&action=review


> Source/WebKit/mac/WebView/WebDataSource.mm:93
> +static inline WebDataSourcePrivate* castPrivate(void* privateAttribute)
>  {

We usually call these cast functions "toFoo" so toPrivate(void* ptr) would be
better here.


More information about the webkit-reviews mailing list