[webkit-reviews] review denied: [Bug 91664] [Qt][WK2] expose element rect for color input type : [Attachment 153085] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Pierre Rossi
<pierre.rossi at gmail.com>'s request for review:
Bug 91664: [Qt][WK2] expose element rect for color input type
https://bugs.webkit.org/show_bug.cgi?id=91664

Attachment 153085: Patch
https://bugs.webkit.org/attachment.cgi?id=153085&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153085&action=review


You had better split the patch into the WebCore part and the WebKit2 part.

> Source/WebCore/platform/ColorChooserClient.h:20
> +    virtual IntRect elementRect() const = 0;

Need a comment about rect in what; in frame? in RootView? in window? in screen?

Or rename the function like elementRectInWindow()