[webkit-reviews] review granted: [Bug 90039] Avoid calling GraphicsContext drawing primitives for 0px borders : [Attachment 152126] Better fix 1: Added more checks and ASSERTs.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 90039: Avoid calling GraphicsContext drawing primitives for 0px borders
https://bugs.webkit.org/show_bug.cgi?id=90039

Attachment 152126: Better fix 1: Added more checks and ASSERTs.
https://bugs.webkit.org/attachment.cgi?id=152126&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152126&action=review


Seems reasonable.  But I worry we're just papering over issues here.

> Source/WebCore/ChangeLog:12
> +	   0px borders, regardless of the border-style, will not be painted.
Thus this is a waste
> +	   of time on all platforms. On Chromium, this trigger some issues with
pdf rendering as
> +	   Skia interprets 0px lines as very thin lines.

I'm not saying we shouldn't do this change... but it seems like this differnece
in skia is a more general problem, which needs to be fixed. 
GraphicsContextSkia should just discard any 0px lines if that matches other
platforms?