[webkit-reviews] review denied: [Bug 85826] RenderMediaControlsChromium unsigned negation warning : [Attachment 140587] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 18 15:32:15 PDT 2012
Adrienne Walker <enne at google.com> has denied Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 85826: RenderMediaControlsChromium unsigned negation warning
https://bugs.webkit.org/show_bug.cgi?id=85826
Attachment 140587: Patch
https://bugs.webkit.org/attachment.cgi?id=140587&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
If this warning is still happening, this is an actual bug. C4146 says that
both the operand and the result are non-negative. For what it's worth, I'm
happy to R+ anything that removes warnings on Windows.
Unfortunately, this code doesn't look like it exists any more. Sad trombone
noise.
More information about the webkit-reviews
mailing list