[webkit-reviews] review granted: [Bug 91555] [chromium] Ubercomp: clean up CCRenderer interface : [Attachment 153082] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 91555: [chromium] Ubercomp: clean up CCRenderer interface
https://bugs.webkit.org/show_bug.cgi?id=91555

Attachment 153082: Patch
https://bugs.webkit.org/attachment.cgi?id=153082&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153082&action=review


R=me.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:555
> +    m_layerRenderer->drawFrame(frame.renderPasses, m_rootScissorRect);
> +    if (m_headsUpDisplay->enabled(settings()))
> +	   m_headsUpDisplay->draw(this);
> +    m_layerRenderer->finishDrawingFrame();

It's a little weird to me to have this asymmetric finish function without an
exposed begin, but I understand that you need to draw some extra stuff in the
frame here.  The heads up display is a little bit of a wart, and I'm not sure
if it should be generating quads or be completely contained within LRC or
something else.  Refactoring for the future, I guess.