[webkit-reviews] review granted: [Bug 11355] Content size of child having percent height inside a fixed height container having overflow:auto is wrongly calculated : [Attachment 153069] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Pravin D
<pravind.2k4 at gmail.com>'s request for review:
Bug 11355: Content size of child having percent height inside a fixed height
container having overflow:auto is wrongly calculated
https://bugs.webkit.org/show_bug.cgi?id=11355

Attachment 153069: Patch
https://bugs.webkit.org/attachment.cgi?id=153069&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153069&action=review


> Source/WebCore/rendering/RenderBox.cpp:2131
> +	   // height.

Nit: you can move the last word of the comment to the previous line.

>
LayoutTests/fast/overflow/child-100percent-height-inside-fixed-container-with-o
verflow-auto.html:22
> +if(window.layoutTestController)

It should be window.testRunner (we are renaming layoutTestController, see
thread on webkit-dev about that).

I would rather have one representation between DRT and non-DRT. Something like:


<a
href="https://bugs.webkit.org/show_bug.cgi?id=11355">https://bugs.webkit.org/sh
ow_bug.cgi?id=11355</a>

would dump in the same manner in DRT and a browser.

>
LayoutTests/fast/overflow/replaced-child-100percent-height-inside-fixed-contain
er-with-overflow-auto.html:25
> +if(window.layoutTestController)
> +    linkToBug = 'Bug https://bugs.webkit.org/show_bug.cgi?id=11355';
> +else
> +    linkToBug = '<a href="https://bugs.webkit.org/show_bug.cgi?id=11355">Bug
#11355</a>';

Same comment.