[webkit-reviews] review requested: [Bug 91644] [BlackBerry] Allow nested suspend/resume screen & backingstore calls : [Attachment 153066] Better & smaller patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 18 12:30:31 PDT 2012
Jakob Petsovits <jpetsovits at rim.com> has asked for review:
Bug 91644: [BlackBerry] Allow nested suspend/resume screen & backingstore calls
https://bugs.webkit.org/show_bug.cgi?id=91644
Attachment 153066: Better & smaller patch
https://bugs.webkit.org/attachment.cgi?id=153066&action=review
------- Additional Comments from Jakob Petsovits <jpetsovits at rim.com>
This one incorporates Adam's suggestions (good catch for the bad return) and
simplifies the patch by not changing the zoomAboutPoint() signature, instead
putting resume calls after zoomAboutPoint() in the two cases where we would
before use that method to resume implicitly. This makes the zoomChanged()
notification come before the render/blit, but nothing says that zoomChanged()
needs to come after the target surface has been updated so that should be ok.
More information about the webkit-reviews
mailing list