[webkit-reviews] review denied: [Bug 91644] [BlackBerry] Allow nested suspend/resume screen & backingstore calls : [Attachment 153060] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 18 11:53:14 PDT 2012
Adam Treat <atreat at rim.com> has denied Jakob Petsovits <jpetsovits at rim.com>'s
request for review:
Bug 91644: [BlackBerry] Allow nested suspend/resume screen & backingstore calls
https://bugs.webkit.org/show_bug.cgi?id=91644
Attachment 153060: Patch
https://bugs.webkit.org/attachment.cgi?id=153060&action=review
------- Additional Comments from Adam Treat <atreat at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=153060&action=review
See comments.
> Source/WebKit/blackberry/Api/BackingStore.cpp:286
> + return;
Uhm, you are returning here... not increasing the counter. What gives?
> Source/WebKit/blackberry/Api/BackingStore.cpp:313
> + "Call mismatch: Backingstore hasn't been suspended, therefore
won't resume!");
How about: "Call mismatch: Screen and backingstore haven't been suspended,
therefore won't resume!"
> Source/WebKit/blackberry/Api/BackingStore_p.h:339
> + int m_suspendBackingStoreUpdates;
unsigned int here?
More information about the webkit-reviews
mailing list