[webkit-reviews] review granted: [Bug 91564] Element wants to have userAgentShadowRoot() : [Attachment 152930] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 91564: Element wants to have userAgentShadowRoot()
https://bugs.webkit.org/show_bug.cgi?id=91564

Attachment 152930: Patch
https://bugs.webkit.org/attachment.cgi?id=152930&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=152930&action=review


This is much cleaner, thanks!

> Source/WebCore/html/HTMLMediaElement.cpp:4185
> +    if (ShadowRoot* userAgent = userAgentShadowRoot()) {
> +	   Node* node = userAgent->firstChild();
> +	   return node && node->isMediaControls();
> +    }

Isn't it true that userAgentShadowRoot()->firstChild() *must* be the media
controls? If so, I think "&& node->isMediaControls()" could be replaced with
"ASSERT(node->isMediaControls())".