[webkit-reviews] review granted: [Bug 91519] Web Inspector: remove search replace from behind experiment, polish the behavior : [Attachment 153000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 18 06:36:30 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 91519: Web Inspector: remove search replace from behind experiment, polish
the behavior
https://bugs.webkit.org/show_bug.cgi?id=91519

Attachment 153000: Patch
https://bugs.webkit.org/attachment.cgi?id=153000&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153000&action=review


> Source/WebCore/English.lproj/localizedStrings.js:726
> +localizedStrings["Replace & Find"] = "Replace & Find";

Please update properly.

> Source/WebCore/inspector/front-end/SearchController.js:202
> +	   this._findButtonElement.disabled = !enabled;

Let's always enable this button.


More information about the webkit-reviews mailing list