[webkit-reviews] review granted: [Bug 91531] Web Inspector: intern strings when processing timeline records : [Attachment 153002] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 91531: Web Inspector: intern strings when processing timeline records
https://bugs.webkit.org/show_bug.cgi?id=91531

Attachment 153002: Patch
https://bugs.webkit.org/attachment.cgi?id=153002&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=153002&action=review


> Source/WebCore/inspector/front-end/TimelinePresentationModel.js:635
> +	   if (!this._details)

Is this a part of a different change?

> Source/WebCore/inspector/front-end/utilities.js:729
> +	   if (string === "__proto__")

What does this mean?

> Source/WebCore/inspector/front-end/utilities.js:741
> +	   this._strings = { __proto__: null };

Object.create(null)