[webkit-reviews] review granted: [Bug 90880] Web Inspector: adding pause icon for JavaScript debugging : [Attachment 152994] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90880: Web Inspector: adding pause icon for JavaScript debugging
https://bugs.webkit.org/show_bug.cgi?id=90880

Attachment 152994: Patch
https://bugs.webkit.org/attachment.cgi?id=152994&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152994&action=review


Please fix OwnPtr nits prior to landing.

> Source/WebCore/inspector/DOMNodeHighlighter.cpp:533
> +    if (m_highlightData) {

// FIXME: Clear entire highlight data here, store config upon
setInspectModeEnabled

> Source/WebCore/inspector/DOMNodeHighlighter.h:96
> +    void setHighlightData(PassOwnPtr<HighlightData>);

I.e. highlightNode will merge with the setHighlightData.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:985
> +	   m_overlay->highlightNode(node);

You should pass m_inspectModeHighlightData here (in the subsequent change).

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1009
> +    HighlightData* highlightData = new HighlightData();

You should always adoptPtr upon creation.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1029
> +    HighlightData* highlightData = new HighlightData();

ditto

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1054
> +	   HighlightData* highlightData = new HighlightData();

ditto