[webkit-reviews] review denied: [Bug 91593] Implement datalist UI for input type color : [Attachment 152967] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 91593: Implement datalist UI for input type color
https://bugs.webkit.org/show_bug.cgi?id=91593

Attachment 152967: Patch
https://bugs.webkit.org/attachment.cgi?id=152967&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
This doesn't look a good design.

We should pass color choices in the linked <datalist> to ColorChooser, and the
color choice support should be implemented in platform-specific layers because
Windows' ChooseColor() has a feature to specify predefined colors
(CHOOSECOLOR::lpCustColors) and OSX's NSColorPicker has attachColorList. Using
PagePopup should be a remedy for platforms of which color choosers have no such
capability, or it would be a common UI for a multiplatform port like Chromium.