[webkit-reviews] review denied: [Bug 91580] [WK2][EFL] Add a common code using Color instead of QColor : [Attachment 152924] patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied YoungTaeck Song
<youngtaeck.song at samsung.com>'s request for review:
Bug 91580: [WK2][EFL] Add a common code using Color instead of QColor
https://bugs.webkit.org/show_bug.cgi?id=91580

Attachment 152924: patch
https://bugs.webkit.org/attachment.cgi?id=152924&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152924&action=review


> Source/WebKit2/UIProcess/texmap/LayerBackingStore.cpp:149
> +#if PLATFORM(QT)
>	   textureMapper->drawBorder(QColor(Qt::red), 2, tile->rect(),
transform);
> +#else
> +	   textureMapper->drawBorder(Color(Color::lightGray), 2, tile->rect(),
transform);
> +#endif

I think it would be better to _replace_ the use of QColor with Color (and
either stick to lightGray or add red to Color::). Let's avoid #ifdefs if we can
:)