[webkit-reviews] review granted: [Bug 91549] Replace uses of RenderBox::x(), y() in rendering code with with point and size methods : [Attachment 152856] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 17 22:58:56 PDT 2012


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 91549: Replace uses of RenderBox::x(), y() in rendering code with with
point and size methods
https://bugs.webkit.org/show_bug.cgi?id=91549

Attachment 152856: Patch
https://bugs.webkit.org/attachment.cgi?id=152856&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=152856&action=review


LGTM.

> Source/WebCore/rendering/RenderBox.cpp:1607
>  void RenderBox::repaintDuringLayoutIfMoved(const LayoutRect& rect)

Seems this argument should be called oldRect?


More information about the webkit-reviews mailing list